Discussion:
[chromium-dev] Re: PSA: Chromium Code Search history view is now 200x faster.
Julie Parent
2018-11-07 03:06:00 UTC
Permalink
Congrats on this roll out! This is an impressive improvement :)
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you can
stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A few
hours ago we rolled out new performance improvements to our Git backend,
so this is no longer the case. Requests should now be blazingly fast,
taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use another
repository for which history is excessively slow, let us know and we will
consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after the
file has been added to the repository.
-
This only applies to history for individual files. Directory history
performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEKrViSextOOYO-d06kRoxKe5fpt9i3D-qZTvNhunzjmD5yVQg%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEKrViSextOOYO-d06kRoxKe5fpt9i3D-qZTvNhunzjmD5yVQg%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAEKrViSextOOYO-d06kRoxKe5fpt9i3D-qZTvNhunzjmD5yVQg%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAEKrViSextOOYO-d06kRoxKe5fpt9i3D-qZTvNhunzjmD5yVQg%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAPSmAARx7g-1zERr_hetWnHx3Wwaoe_ntiOX2k0aWeTqOLyjuA%40mail.gmail.com.
c***@chromium.org
2018-11-07 04:05:06 UTC
Permalink
This is awesome! It's really blazing fast right now even for files with a
long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you can
stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A few
hours ago we rolled out new performance improvements to our Git backend,
so this is no longer the case. Requests should now be blazingly fast,
taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use another
repository for which history is excessively slow, let us know and we will
consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after the
file has been added to the repository.
-
This only applies to history for individual files. Directory history
performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+***@chromium.org.
To post to this group, send email to infra-***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org.
Charlie Andrews
2018-11-07 16:52:32 UTC
Permalink
This is *awesome. *Looks like blame overlay also got much faster. Thanks so
much for fixing this problem! I'd frequently click "blame" or "history" and
then go do something else for a minute, which was really disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files with a
long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you
can stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A few
hours ago we rolled out new performance improvements to our Git backend,
so this is no longer the case. Requests should now be blazingly fast,
taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use another
repository for which history is excessively slow, let us know and we will
consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after the
file has been added to the repository.
-
This only applies to history for individual files. Directory history
performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com.
Mason Freed
2018-11-07 16:57:32 UTC
Permalink
Very cool! I would often click Blame, go do something else, and then forget
what I was doing by the time it finished. This is very nice.
Post by Charlie Andrews
This is *awesome. *Looks like blame overlay also got much faster. Thanks
so much for fixing this problem! I'd frequently click "blame" or "history"
and then go do something else for a minute, which was really disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files with
a long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you
can stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A few
hours ago we rolled out new performance improvements to our Git
backend, so this is no longer the case. Requests should now be blazingly
fast, taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use another
repository for which history is excessively slow, let us know and we will
consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after the
file has been added to the repository.
-
This only applies to history for individual files. Directory history
performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+***@chromium.org.
To post to this group, send email to infra-***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com.
Dave Tapuska
2018-11-07 17:01:17 UTC
Permalink
I always used "View In Git Blame" to open another tab so I didn't
experience an improvement. But wow the overlay is much better to use now.
It is possible to use the same backend to service URIs of the format:
https://chromium.googlesource.com/chromium/src/+blame/HEAD/ ?

dave.
Post by Mason Freed
Very cool! I would often click Blame, go do something else, and then
forget what I was doing by the time it finished. This is very nice.
Post by Charlie Andrews
This is *awesome. *Looks like blame overlay also got much faster. Thanks
so much for fixing this problem! I'd frequently click "blame" or "history"
and then go do something else for a minute, which was really disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files with
a long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you
can stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A few
hours ago we rolled out new performance improvements to our Git
backend, so this is no longer the case. Requests should now be blazingly
fast, taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use another
repository for which history is excessively slow, let us know and we will
consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after the
file has been added to the repository.
-
This only applies to history for individual files. Directory
history performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+***@chromium.org.
To post to this group, send email to infra-***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com.
Erik Chen
2018-11-07 17:20:02 UTC
Permalink
This is awesome work. I usually give up in frustration when trying to load
history and now it's instant. :)
Post by Dave Tapuska
I always used "View In Git Blame" to open another tab so I didn't
experience an improvement. But wow the overlay is much better to use now.
https://chromium.googlesource.com/chromium/src/+blame/HEAD/ ?
dave.
Post by Mason Freed
Very cool! I would often click Blame, go do something else, and then
forget what I was doing by the time it finished. This is very nice.
Post by Charlie Andrews
This is *awesome. *Looks like blame overlay also got much faster.
Thanks so much for fixing this problem! I'd frequently click "blame" or
"history" and then go do something else for a minute, which was really
disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files
with a long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>, you
can stop reading now.
As you may be aware, the history view in Chromium Code Search has been
slooooowwwwww <https://crbug.com/666987> for the last few years. A
few hours ago we rolled out new performance improvements to our Git
backend, so this is no longer the case. Requests should now be blazingly
fast, taking ~250ms instead of >50s.
-
This is only rolled out for https://chromium.googlesource.
com/chromium/src. If you use another repository for which history
is excessively slow, let us know and we will consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after
the file has been added to the repository.
-
This only applies to history for individual files. Directory
history performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-
8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-
5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%
3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%
3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRf
U23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRf
U23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%
3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_
xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEYHnr38vS%3Db1Xfaj%3DWVa8H%3DhNmqvdH8YkxojUWZMfOSrjPCVg%40mail.gmail.com.
Andrii Shyshkalov
2018-11-07 19:16:16 UTC
Permalink
Lightning speed all the way to 2008
<https://cs.chromium.org/chromium/src/base/test/test_suite.h?q=base_test&sq=package:chromium&dr=CSs&l=5>!
WOW. Thank you!

Is there some kind of quota constraining rollout to other repos in
chromium/src DEPS tree?
Post by Erik Chen
This is awesome work. I usually give up in frustration when trying to load
history and now it's instant. :)
Post by Dave Tapuska
I always used "View In Git Blame" to open another tab so I didn't
experience an improvement. But wow the overlay is much better to use now.
https://chromium.googlesource.com/chromium/src/+blame/HEAD/ ?
dave.
Post by Mason Freed
Very cool! I would often click Blame, go do something else, and then
forget what I was doing by the time it finished. This is very nice.
Post by Charlie Andrews
This is *awesome. *Looks like blame overlay also got much faster.
Thanks so much for fixing this problem! I'd frequently click "blame" or
"history" and then go do something else for a minute, which was really
disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files
with a long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>,
you can stop reading now.
As you may be aware, the history view in Chromium Code Search has
been slooooowwwwww <https://crbug.com/666987> for the last few
years. A few hours ago we rolled out new performance improvements to
our Git backend, so this is no longer the case. Requests should now be
blazingly fast, taking ~250ms instead of >50s.
-
This is only rolled out for
https://chromium.googlesource.com/chromium/src. If you use
another repository for which history is excessively slow, let us know and
we will consider adding it to the list.
-
Performance for new files will be slow for up to 12 hours after
the file has been added to the repository.
-
This only applies to history for individual files. Directory
history performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
Post by Dave Tapuska
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEYHnr38vS%3Db1Xfaj%3DWVa8H%3DhNmqvdH8YkxojUWZMfOSrjPCVg%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEYHnr38vS%3Db1Xfaj%3DWVa8H%3DhNmqvdH8YkxojUWZMfOSrjPCVg%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+***@chromium.org.
To post to this group, send email to infra-***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CADzH4%2BvJyHdQuM0zKqpZcqeizfVyy0Kg%2Br%3DK1nvW7TVEpWkNgQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CADzH4%2BvJyHdQuM0zKqpZcqeizfVyy0Kg%2Br%3DK1nvW7TVEpWkNgQ%40mail.gmail.com.
Owen Rodley
2018-11-09 01:08:49 UTC
Permalink
Thanks everyone.

Regarding blame - I should point out that as much as I'd like to take
credit for blame performance (loading the blame annotations), this wasn't
me. It was improved by a similar change several years ago.
This change does indirectly improve the blame overlay though, as clicking
on any of the links opens up the history view, and hence depends on its
performance.

dtapuska@: Gitiles uses the same backend for blame, so all blame requests
should be just as fast there. Do you have any example blame requests which
are faster from Code Search than from Gitiles?

tandrii@: No, we should be okay on quota. If you have any other repos in
mind let me know.
Post by Andrii Shyshkalov
Lightning speed all the way to 2008
<https://cs.chromium.org/chromium/src/base/test/test_suite.h?q=base_test&sq=package:chromium&dr=CSs&l=5>!
WOW. Thank you!
Is there some kind of quota constraining rollout to other repos in
chromium/src DEPS tree?
Post by Erik Chen
This is awesome work. I usually give up in frustration when trying to
load history and now it's instant. :)
Post by Dave Tapuska
I always used "View In Git Blame" to open another tab so I didn't
experience an improvement. But wow the overlay is much better to use now.
https://chromium.googlesource.com/chromium/src/+blame/HEAD/ ?
dave.
Post by Mason Freed
Very cool! I would often click Blame, go do something else, and then
forget what I was doing by the time it finished. This is very nice.
Post by Charlie Andrews
This is *awesome. *Looks like blame overlay also got much faster.
Thanks so much for fixing this problem! I'd frequently click "blame" or
"history" and then go do something else for a minute, which was really
disruptive.
Post by c***@chromium.org
This is awesome! It's really blazing fast right now even for files
with a long history
<https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.h>.
Thanks!
Hi all,
If you don't use Chromium Code Search <https://cs.chromium.org/>,
you can stop reading now.
As you may be aware, the history view in Chromium Code Search has
been slooooowwwwww <https://crbug.com/666987> for the last few
years. A few hours ago we rolled out new performance improvements
to our Git backend, so this is no longer the case. Requests should now be
blazingly fast, taking ~250ms instead of >50s.
-
This is only rolled out for https://chromium.googlesource.
com/chromium/src. If you use another repository for which
history is excessively slow, let us know and we will consider adding it to
the list.
-
Performance for new files will be slow for up to 12 hours after
the file has been added to the repository.
-
This only applies to history for individual files. Directory
history performance is unchanged.
If you have any issues, please feel free to file feedback either in
Monorail (using the Infra>Codesearch component) or using the "Feedback"
link in Code Search itself.
Thanks,
Owen
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it,
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-
8c31-5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-
5fc486fb50a9%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/480b9764-7f22-48ce-8c31-5fc486fb50a9%40chromium.org?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%
3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%
3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPTbymd8SdeKSSHpphMFca%3DwwTrL7n8Op9%3Drt-WxSUNSjO6kvA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRf
U23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRf
U23oP6um2vUy7Mf5pWA%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAM%3DNeDhJFmo0xXLWwsHYVEH814sMbRfU23oP6um2vUy7Mf5pWA%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google
Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%
3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/
Post by Dave Tapuska
chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%
3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHgVhZWQDbSCW4h4%3Dfbdw0L-aoB%2B_RfjUK_xot8c9XAPOmkH5g%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CAEYHnr38vS%3Db1Xfaj%3DWVa8H%
3DhNmqvdH8YkxojUWZMfOSrjPCVg%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEYHnr38vS%3Db1Xfaj%3DWVa8H%3DhNmqvdH8YkxojUWZMfOSrjPCVg%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
You received this message because you are subscribed to the Google Groups
"infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit https://groups.google.com/a/
chromium.org/d/msgid/infra-announce/CADzH4%2BvJyHdQuM0zKqpZcqeizfVyy0Kg%
2Br%3DK1nvW7TVEpWkNgQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CADzH4%2BvJyHdQuM0zKqpZcqeizfVyy0Kg%2Br%3DK1nvW7TVEpWkNgQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOdR588Bhnyd9dCiYJ%2B%2BSY1NnDXxgqNFD7Zmsvn2aXEn1D%2BnWw%40mail.gmail.com.
Loading...