[chromium-dev] Add new Folder and Files inside Xcode

[M shauket]

Hi,

I tried to add new files and folder inside iOS directory of chromium code
and add these folder and files inside chrom target in XCode, also setup
Build.gn file in each folder. after run this command

ios/build/tools/setup-gn.py


it remove folder and files from Xcode. Kindly guide me what should I need
to do.


Thanks in advance.

[o***@chromium.org]

You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium code
and add these folder and files inside chrom target in XCode, also setup
Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I need
to do.
Thanks in advance.

[M shauket]

Hi i added file path in Build.gn file.

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium code
and add these folder and files inside chrom target in XCode, also setup
Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I need
to do.
Thanks in advance.

--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org?utm_medium=email&utm_source=footer>
.

--
Sent from Gmail Mobile

[Yuke Liao]

It is hard to debug without more details.

How did you add the dirs/files? It would be great if you can upload a patch
with your diffs and provide steps for reproducing.

Post by M shauket
Hi i added file path in Build.gn file.

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium
code and add these folder and files inside chrom target in XCode, also
setup Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I
need to do.
Thanks in advance.

--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org?utm_medium=email&utm_source=footer>
.

--
Sent from Gmail Mobile
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

[M shauket]

Hi @yuki I attached folder kindly extract and put in src-> iOS -> rakuten ,
also replace of iOS BUILD.GN within provided.

Post by Yuke Liao
It is hard to debug without more details.
How did you add the dirs/files? It would be great if you can upload a
patch with your diffs and provide steps for reproducing.

Post by M shauket
Hi i added file path in Build.gn file.

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium
code and add these folder and files inside chrom target in XCode, also
setup Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I
need to do.
Thanks in advance.

--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org?utm_medium=email&utm_source=footer>
.

--
Sent from Gmail Mobile
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

[o***@chromium.org]

There are multiple issues

- Your base tree is outdated. please rebase before sending
- You don't provide the ios BUILD.gn but the root BUILD.gn, which does not
contain any reference to your new files.
- do not send archive of files. Send a git patch.

, also replace of iOS BUILD.GN within provided.

Post by Yuke Liao
It is hard to debug without more details.
How did you add the dirs/files? It would be great if you can upload a
patch with your diffs and provide steps for reproducing.

Post by M shauket
Hi i added file path in Build.gn file.

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium
code and add these folder and files inside chrom target in XCode, also
setup Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I
need to do.
Thanks in advance.

--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org?utm_medium=email&utm_source=footer>
.

--
Sent from Gmail Mobile
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

[M shauket]

Root BUILD.gn file contain ref. "//ios/rakuten" , thanks i solved this
issue, issues was I added all_test files inside Base Build.gn file.

Post by o***@chromium.org
There are multiple issues
- Your base tree is outdated. please rebase before sending
- You don't provide the ios BUILD.gn but the root BUILD.gn, which does not
contain any reference to your new files.
- do not send archive of files. Send a git patch.

, also replace of iOS BUILD.GN within provided.

Post by Yuke Liao
It is hard to debug without more details.
How did you add the dirs/files? It would be great if you can upload a
patch with your diffs and provide steps for reproducing.

Post by M shauket
Hi i added file path in Build.gn file.

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium
code and add these folder and files inside chrom target in XCode, also
setup Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I
need to do.
Thanks in advance.

--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/20b9b008-8b87-4a56-8310-1ba5ab7611dc%40chromium.org?utm_medium=email&utm_source=footer>
.

--
Sent from Gmail Mobile
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAOsdmQ2Pneu0RhqMOTNTGrukU8vG7NWr_TBn62E84KQ9eNps%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
.

[M shauket]

Hi here is added files like this way.

created folder inside iOS folder , foldername -> newfolder -> newfolder ,
created build.gn in each folder also files inside these folder added deps
and in source set as well. But GN command not showing proper error

Traceback (most recent call last):

File "ios/build/tools/setup-gn.py", line 351, in <module>

sys.exit(Main(sys.argv[1:]))

File "ios/build/tools/setup-gn.py", line 346, in Main

GenerateXcodeProject(gn_path, args.root, out_dir, settings)

File "ios/build/tools/setup-gn.py", line 269, in GenerateXcodeProject

generator.Generate(gn_path, root_dir, temp_path)

File "ios/build/tools/setup-gn.py", line 130, in Generate

self.GetGnCommand(gn_path, root_path, out_path, True))

File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 540, in check_call

raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['/Chromium/depot_tools/gn',
'--root=/Chromium/chromium/src', '-q', '--ide=xcode',
'--root-target=gn_all',
'--filters=//base:base_unittests;//components:components_unittests;//crypto:crypto_unittests;//google_apis:google_apis_unittests;//ios/*;//ios_internal/*;//net:net_unittests;//services:services_unittests;//skia:skia_unittests;//sql:sql_unittests;//ui/base:ui_base_unittests;//ui/gfx:gfx_unittests;//url:url_unittests',
'gen', '//out/_templ2JK4Y']' returned non-zero exit status 1

Post by o***@chromium.org
You need to manually add the files in the BUILD.gn file.

Post by M shauket
Hi,
I tried to add new files and folder inside iOS directory of chromium code
and add these folder and files inside chrom target in XCode, also setup
Build.gn file in each folder. after run this command
ios/build/tools/setup-gn.py
it remove folder and files from Xcode. Kindly guide me what should I need
to do.
Thanks in advance.