Discussion:
[chromium-dev] Trying to find webkit
Emett Speer
2018-11-01 23:13:37 UTC
Permalink
I have been looking for webkit for a couple hours now and can't see to find
the location yet. Would anyone be able to point me in the right direction
as the documentation is outdated and is pointing me to folders that no
longer exist.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org.
Christian Biesinger
2018-11-01 23:30:44 UTC
Permalink
We are not using webkit anymore, instead we use a fork called blink. It's
in third_party/blink/renderer.


What docs were you using, so we can update them?

Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see to
find the location yet. Would anyone be able to point me in the right
direction as the documentation is outdated and is pointing me to folders
that no longer exist.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAPTJ0XG%2BTdtkkHX27%2BxrNGemcdW-wPsaUJg64jEgev%2BC-HTDNA%40mail.gmail.com.
Emett Speer
2018-11-01 23:33:43 UTC
Permalink
Thank you for getting back to me Christian.

The documentation in question is at this URL
https://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
under Top-level projects.

On Thursday, November 1, 2018 at 4:31:41 PM UTC-7, Christian Biesinger
Post by Christian Biesinger
We are not using webkit anymore, instead we use a fork called blink. It's
in third_party/blink/renderer.
What docs were you using, so we can update them?
Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see to
find the location yet. Would anyone be able to point me in the right
direction as the documentation is outdated and is pointing me to folders
that no longer exist.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e-a494-423e-9b51-0eaf60125c02%40chromium.org.
Daniel Bratell
2018-11-02 15:58:28 UTC
Permalink
That document is indeed not fully up to date. I just did some small
changes to it to replace WebKit with Blink and removed other parts I know
not to be useful information anymore so the next person reading it will be
in a better position.

Keeping documentation up-to-date is hard even when it's a wiki.

/Daniel
Post by Emett Speer
Thank you for getting back to me Christian.
The documentation in question is at this URL
https://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
under Top->level projects.
On Thursday, November 1, 2018 at 4:31:41 PM UTC-7, Christian Biesinger
Post by Christian Biesinger
We are not using webkit anymore, instead we use a fork called blink.
It's in third_party/blink/renderer.
What docs were you using, so we can update them?
Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see to
find the location yet. Would anyone be able to point me in the right
Post by Emett Speer
direction as the documentation is outdated and is pointing me to
folders that no longer exist.
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883->>>c783-4cb2-9fd4-4909e3a34849%40chromium.org.
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e->a494-423e-9b51-0eaf60125c02%40chromium.org.
--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/op.zruzzqlprbppqq%40cicero2.linkoping.osa.
Emett Speer
2018-11-02 20:56:16 UTC
Permalink
Thank you for the documentation update Daniel.
Post by Daniel Bratell
That document is indeed not fully up to date. I just did some small
changes to it to replace WebKit with Blink and removed other parts I know
not to be useful information anymore so the next person reading it will be
in a better position.
Keeping documentation up-to-date is hard even when it's a wiki.
/Daniel
Thank you for getting back to me Christian.
The documentation in question is at this URL
https://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
under Top-level projects.
On Thursday, November 1, 2018 at 4:31:41 PM UTC-7, Christian Biesinger
Post by Christian Biesinger
We are not using webkit anymore, instead we use a fork called blink. It's
in third_party/blink/renderer.
What docs were you using, so we can update them?
Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see to
find the location yet. Would anyone be able to point me in the right
direction as the documentation is outdated and is pointing me to folders
that no longer exist.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e-a494-423e-9b51-0eaf60125c02%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e-a494-423e-9b51-0eaf60125c02%40chromium.org?utm_medium=email&utm_source=footer>
.
--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/71b8ff34-46c3-4862-8d56-fd16cfba35dc%40chromium.org.
Avi Drissman
2018-11-02 21:03:00 UTC
Permalink
That page is... oh wow. From the "Code paths for common operations" section:

It will create a new TabContents object from
browser/tab_contents/tab_contents.cc
I killed TabContents back in 2012. Is there anything salvageable from that
section?

Avi
Thank you for the documentation update Daniel.
Post by Daniel Bratell
That document is indeed not fully up to date. I just did some small
changes to it to replace WebKit with Blink and removed other parts I know
not to be useful information anymore so the next person reading it will be
in a better position.
Keeping documentation up-to-date is hard even when it's a wiki.
/Daniel
Thank you for getting back to me Christian.
The documentation in question is at this URL
https://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
under Top-level projects.
On Thursday, November 1, 2018 at 4:31:41 PM UTC-7, Christian Biesinger
Post by Christian Biesinger
We are not using webkit anymore, instead we use a fork called blink.
It's in third_party/blink/renderer.
What docs were you using, so we can update them?
Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see to
find the location yet. Would anyone be able to point me in the right
direction as the documentation is outdated and is pointing me to folders
that no longer exist.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883-c783-4cb2-9fd4-4909e3a34849%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e-a494-423e-9b51-0eaf60125c02%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e-a494-423e-9b51-0eaf60125c02%40chromium.org?utm_medium=email&utm_source=footer>
.
--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */
--
--
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups
"Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/71b8ff34-46c3-4862-8d56-fd16cfba35dc%40chromium.org
<https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/71b8ff34-46c3-4862-8d56-fd16cfba35dc%40chromium.org?utm_medium=email&utm_source=footer>
.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAa5Bz8P_SfKFA7rLNg53PFZVGB8aiyuX83XT4QHe-FiMw%40mail.gmail.com.
Daniel Bratell
2018-11-05 12:26:25 UTC
Permalink
I suspect not, since so much code has been completely rewritten.
Navigation is probably not even close to anything anymore (but I don't
know for sure).

Maybe there should be a "best before" on every documentation snippet.

I deleted some small section I knew to be wrong Friday. Misleading
documentation seems worse than no documentation. If you know that part to
be wrong, delete it or update it?

/Daniel
Post by Avi Drissman
Post by Avi Drissman
It will create a new TabContents object from
browser/tab_contents/tab_contents.cc
I killed TabContents back in 2012. Is there anything salvageable from
that section?
Avi
Post by Avi Drissman
Thank you for the documentation update Daniel.
Post by Daniel Bratell
That document is indeed not fully up to date. I just did some small
changes to it to replace WebKit with Blink and removed other parts I
know not >>>to be useful information anymore so the next person
reading it will be in a better position.
Keeping documentation up-to-date is hard even when it's a wiki.
/Daniel
Post by Emett Speer
Thank you for getting back to me Christian.
The documentation in question is at this URL
https://www.chromium.org/developers/how-tos/getting-around-the-chrome-source-code
under >>>>Top-level projects.
On Thursday, November 1, 2018 at 4:31:41 PM UTC-7, Christian
Post by Christian Biesinger
We are not using webkit anymore, instead we use a fork called blink.
It's in third_party/blink/renderer.
What docs were you using, so we can update them?
Christian
Post by Emett Speer
I have been looking for webkit for a couple hours now and can't see
to find the location yet. Would anyone be able to point me in the
right >>>>>>direction as the documentation is outdated and is
pointing me to folders that no longer exist.
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the
Google Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/08465883->>>>>>c783-4cb2-9fd4-4909e3a34849%40chromium.org.
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it,
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/490bf62e->>>>a494-423e-9b51-0eaf60125c02%40chromium.org.
--/* Opera Software, Linköping, Sweden: CET (UTC+1) */
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/71b8ff34-46c3-4862-8d56-fd16cfba35dc>>%40chromium.org.
http://groups.google.com/a/chromium.org/group/chromium-dev
---You received this message because you are subscribed to the Google
Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
To view this discussion on the web visit
https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/>CACWgwAa5Bz8P_SfKFA7rLNg53PFZVGB8aiyuX83XT4QHe-FiMw%40mail.gmail.com.
--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/op.zrz96brorbppqq%40cicero2.linkoping.osa.
Loading...