[chromium-dev] [PSA] EnsureCQIncludeTrybotsAreAdded will be removed on November 30

[Edward Lemur]

If you don’t care about triggering extra trybots from PRESUBMIT files, you
can stop reading now.

Hi,

EnsureCqIncludeTrybotsAreAdded in PRESUBMIT files has been replaced by
path_regexp
fields in cq.cfg
<https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/691474>
(see the bottom of the message for details), and will be removed on
November 30.

These changes have been done for Chromium here
<https://chromium-review.googlesource.com/c/chromium/src/+/1265735> and here
<https://chromium-review.googlesource.com/c/chromium/src/+/1266055>. Please
make sure your project has done so as well.

This will make CL uploads less likely to fail due to Gerrit consistency
issues (see issue 881860 <http://crbug.com/881860> for more details), and
it will make it easier to be aware of what builders are being triggered and
take that into account for capacity planning.

Please let us know if you have any questions, requests or comments.

Edward,

On behalf of Chrome Operations team


Definition of path_regexp fields in cq.proto

message Builder {

...

// Require this builder only if path_regexp matches a file in this CL.

//

// This means:

// * If specified and no file in a CL matches any of the path_regex,

// then CQ will not care about this builder.

// * If a file in a CL matches any path_regexp_exclude, then this file

// won't be considered when matching path_regexp.

//

// If not path_regexp is not specified (default),

// builder will be used on all CLs, even those which are not modifying any

// file (just commit description changes).

// TODO(tandrii): CQ shouldn't process such CLs https://crbug.com/892462,

// which would allow to change default path_regexp to '.*', ie matching

// any file.

//

// Path must be relative to root of the repo. Path uses Unix / directory

// separators. The comparison is a full match; the pattern is implicitly

// anchored with "^" and "$", so there is no need add them.

//

// Touching a file means either adding, modifying or removing it.

//

// These options currently can not be combined with the following other
options:

// * experiment_percentage

// * triggered_by

// * GerritCQAbilityVerifier.allow_submit_with_open_deps

// If you need to combine them, please talk to CQ owners.

//

// Examples:

//

// path_regexp: "third_party/WebKit/.+"

// will enable builder for all CLs touching any file in

// third_party/WebKit directory, but not directory itself.

//

// path_regexp: "/root/sudo*"

// will not match any file because of absolute path.

//

// path_regexp: "all/.+"

// path_regexp_exclude: "all/one.txt"

// will match a CL which touches at least one file other than

// 'one.txt' inside all/ directory.

//

// path_regexp_exclude: "one.txt"

// will match a CL which touches at least one file other than

// 'one.txt'. Note, in this case path_regexp defaults to ".*".

repeated string path_regexp = 6;

repeated string path_regexp_exclude = 8;

...

}
--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+***@chromium.org.
To post to this group, send email to infra-***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAJeMwD-oShugVVji0Fcdw1bLUcgJHn4sajP70z%2B6VntboStJ%3DA%40mail.gmail.com.