Discussion:
[chromium-dev] Best way to abstain from Cyclic dependency in iOS
M shauket
2018-11-27 12:33:34 UTC
Permalink
Hi,

what is the best way to abstain from cyclic dependency. I created a folder
inside iOS folder and add extension of toolbar_button_factory class, I
added dpendancies for extension folder but when I run ninja it give me
error like this

ERROR at
//ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm:6:10:
Include not allowed.

#import "ios/rakuten/ui/button/ToolbarButtonFactory+SubClassing.h"


If I include deps for ui/toolbar/buttons/ folder, it say cyclic dpendancy
exist.


*ERROR *Dependency cycle:

//ios/chrome/browser/ui/toolbar/buttons:buttons ->

//ios/rakuten/ui/button:button ->

//ios/chrome/browser/ui/toolbar/buttons:buttons


Can anyone tell me what is the thum rul to fix dependancy issue. Thanks in
Advance.
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/a6405f1a-e3b1-4b2c-abaa-44e12938ce07%40chromium.org.
Loading...