'Max Rebuschatis' via Chromium-dev
2018-11-09 19:03:39 UTC
See this
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1315727/1
I made a change to DEPS to change the sha of the commit for the
third_party/arcore-android-sdk subrepo in an upstream
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1277837.
When I do gclient sync locally, the correct arcore_c_api.h file from that
subrepo gets pulled down which includes the HitTestRay variant of the
HitTest API.
On CQ on the builder, this doesn't seem to work and I am getting a compile
error complaining that this new HitTest method variant doesn't exist.
Anyone have an idea why this DEPS change isn't working? As you can see
here, the DEPS change does appear to be being pulled in from the upstream
CL:
https://chromium.googlesource.com/chromium/src/+log/daf40520eb262030e527e1960dc34946f4c47633
<https://www.google.com/url?q=https://chromium.googlesource.com/chromium/src/%2Blog/daf40520eb262030e527e1960dc34946f4c47633&sa=D&source=hangouts&ust=1541870327135000&usg=AFQjCNEfVCjgek6ljFJFxmSk9f-A3bAR3g>
Thanks!
-Max
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1315727/1
I made a change to DEPS to change the sha of the commit for the
third_party/arcore-android-sdk subrepo in an upstream
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1277837.
When I do gclient sync locally, the correct arcore_c_api.h file from that
subrepo gets pulled down which includes the HitTestRay variant of the
HitTest API.
On CQ on the builder, this doesn't seem to work and I am getting a compile
error complaining that this new HitTest method variant doesn't exist.
Anyone have an idea why this DEPS change isn't working? As you can see
here, the DEPS change does appear to be being pulled in from the upstream
CL:
https://chromium.googlesource.com/chromium/src/+log/daf40520eb262030e527e1960dc34946f4c47633
<https://www.google.com/url?q=https://chromium.googlesource.com/chromium/src/%2Blog/daf40520eb262030e527e1960dc34946f4c47633&sa=D&source=hangouts&ust=1541870327135000&usg=AFQjCNEfVCjgek6ljFJFxmSk9f-A3bAR3g>
Thanks!
-Max
--
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/3dfc683a-a5e8-4164-9d17-9c822732123d%40chromium.org.
--
Chromium Developers mailing list: chromium-***@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+***@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/3dfc683a-a5e8-4164-9d17-9c822732123d%40chromium.org.